Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update issue #283

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Fix update issue #283

merged 1 commit into from
Jul 4, 2019

Conversation

TommyLike
Copy link
Contributor

Follow up of patch #277

@TommyLike
Copy link
Contributor Author

Check the CI log before merge

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2019
@k82cn
Copy link
Member

k82cn commented Jul 3, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 3, 2019
@TommyLike TommyLike force-pushed the bug/fix_update_error branch from d1ef272 to 5ad0927 Compare July 3, 2019 08:19
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2019
@TommyLike
Copy link
Contributor Author

resolve conflict issues.

@TommyLike TommyLike mentioned this pull request Jul 3, 2019
Closed
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: eaa1be30-9d6f-11e9-9589-8781193ec3af

@k82cn
Copy link
Member

k82cn commented Jul 4, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2019
@volcano-sh-bot volcano-sh-bot merged commit 294c8ec into volcano-sh:master Jul 4, 2019
kevin-wangzefeng pushed a commit that referenced this pull request Jul 4, 2019
@k82cn
Merge pull request #283 from k82cn/ka_280_1
ccf7a4d 
Checked under request jobs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn Awaiting requested review from k82cn

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TommyLike @k82cn @volcano-sh-bot @TravisBuddy